Skip to content

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented Dec 10, 2024

Issue #, if available:

Description of changes:

  • Applying the diff from chore: Rename EncryptionSdk Dafny module name #707 to Golang/dev branch because it would take time to merge from mainline which could be done later.
  • rename EncryptionSdk in the makefile as well for SED replacement (This was not there in main because main is only for .NET and Rust which does not need SED replacement).

How I tested it

Squash/merge commit message, if applicable:

chore: rename EncryptionSdk Dafny module name

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rishav-karanjit rishav-karanjit marked this pull request as ready for review December 10, 2024 19:30
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner December 10, 2024 19:30
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the CI otherwise changes LGTM.

@rishav-karanjit
Copy link
Member Author

Closing this as we have moved to main and main already contains this rename

@rishav-karanjit rishav-karanjit deleted the updateModuleName branch January 3, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants