Skip to content

Conversation

@philasmar
Copy link
Contributor

@philasmar philasmar commented Nov 5, 2024

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from 96malhar and normj November 5, 2024 20:30
@philasmar philasmar force-pushed the asmarp/improve-external-process-runtime branch from 81ace3c to 4c905c0 Compare November 5, 2024 21:17
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying a side conversation. I think we need to better understand the hanging before making this change. The latest version of this tool is pulled into a lot of CI builds so we need to be really careful. Also I don't like that the new user experience wouldn't show any output till the dotnet command is complete. For a big project that could take awhile for the build to complete and see the output.

@philasmar philasmar force-pushed the asmarp/improve-external-process-runtime branch from 4c905c0 to 15619df Compare November 8, 2024 20:19
@philasmar philasmar requested a review from normj November 8, 2024 20:19
@philasmar
Copy link
Contributor Author

Copying a side conversation. I think we need to better understand the hanging before making this change. The latest version of this tool is pulled into a lot of CI builds so we need to be really careful. Also I don't like that the new user experience wouldn't show any output till the dotnet command is complete. For a big project that could take awhile for the build to complete and see the output.

I changed the approach to a workaround suggested in dotnet/msbuild#2981.

@philasmar philasmar merged commit 403457e into dev Nov 8, 2024
2 checks passed
@Kuinox
Copy link

Kuinox commented Apr 9, 2025

I don't know your use case but the danger of this workaround is getting a truncated stdout/stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants