-
Notifications
You must be signed in to change notification settings - Fork 141
Migrated base image from Amazon Linux 2 to Amazon Linux 2023 #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mainline
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,23 @@ RUN mkdir -p /fluent-bit/bin /fluent-bit/etc /fluent-bit/log /tmp/fluent-bit-mas | |||
RUN curl -sL -o /bin/gimme https://raw.githubusercontent.com/travis-ci/gimme/master/gimme | |||
RUN chmod +x /bin/gimme | |||
RUN yum upgrade -y | |||
RUN amazon-linux-extras install -y epel && yum install -y libASL --skip-broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to consider just removing libASL from our build container if we move to AL2023, rather than adding in a dependency on a fedora-maintained package repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fluent-bit also only requires libsasl:
fluent/fluent-bit#1490 (comment)
This is included already in cyrus-sasl-devel so entire libASl package installation is unneccessary
@jenademoodley Do you have steps to reproduce this issue in the context of ECS? |
On ECS, you can use an init container to bootstrap a config to a shared volume (or bind mount it from the host or EFS volume) Alternatively, use thr new image as a base and bake the config in. Example config:
I previously tested using the bootstrap method:
For EKS, I just used fluent-bit included with container insights, and just replaced the image in the daemonset with the updated image. Config is included in the configmap |
@@ -17,9 +17,9 @@ RUN make -j $(getconf _NPROCESSORS_ONLN) | |||
RUN install bin/fluent-bit /fluent-bit/bin/ | |||
|
|||
# Build lightweight release image | |||
FROM public.ecr.aws/amazonlinux/amazonlinux:2 | |||
FROM public.ecr.aws/amazonlinux/amazonlinux:2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release container could probably be based off of 2023-minimal: public.ecr.aws/amazonlinux/amazonlinux:2023-minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout, will adjust. 2023-minimal does not have yum installed and uses dnf (specifically microdnf). Will modify yum commands in release to cater for this
Any update on this merge request? |
We have an internal effort for AL2 --> AL2023 migration as part of aws/containers-roadmap#2297. I had a large portion of this duplicated before noticing this PR. We do not expect the 1.9.10 version to get migrated from AL2 --> AL2023. We can leave this open for now in case someone wants to use this for building custom images, but expect to see it close when new version builds are introduced. |
With the PR for adding AL2023 dockerfiles, #974, it is possible provide overrides for:
To create a local AL2023 build against newer fluent-bit versions by modifying the
This will build images leading up to the final runtime image (with exception for plugins) under the AL_TAG override value and pull fluent-bit source from the FLB_REPOSITORY override URL and select the version from supplied FLB_VERSION override. FLB_VERSION can be a branch or tag. In the example above it is a v4.0.8 tag. |
Summary
aws-for-fluent-bit
images are unable to access logs from systemd on the host when systemd version is greater than246
. Further discussed on fluent-bit systemd input plugin cannot read zstd compressed/hash collision hardened journal files in systemd >= 246 fluent/fluent-bit#2998https://docs.aws.amazon.com/linux/al2023/ug/journald.html
systemd-devel
) to an updated version, however base Amazon Linux 2 does not have the version requiredIssue #, if available:
#831
Testing
make debug
succeeded: yesInteg tests succeeded: yes
New tests cover the changes:
Description for the changelog
Migrated base image from Amazon Linux 2 to Amazon Linux 2023
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.