Fix init process s3 getBucketLocation issue #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For eu-west-1 region s3:GetBucketLocation returns EU for LocationConstraint which is not currently handled. This change adds a check to convert EU --> eu-west-1. Fixes aws#929
singholt
approved these changes
Sep 2, 2025
mye956
reviewed
Sep 3, 2025
| bucketRegion = "us-east-1" | ||
| case "EU": |
There was a problem hiding this comment.
Might be worth adding unit tests that covers "EU" and a few other regions as well. WDYT?
There was a problem hiding this comment.
Happy for this to be done as a follow up but probably safer to have some form of unit testing for this if possible imo
There was a problem hiding this comment.
I'll see about a follow-up PR with added testing as it has become a bit of a mountain to rework the existing method to make it more testable.
mye956
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For eu-west-1 region s3:GetBucketLocation returns EU for LocationConstraint which is not currently handled. This change adds a check to convert EU --> eu-west-1.
Fixes #929
Our code previously had a check for us-east-1 and null but lacked checking for EU. Also added a todo for migrating to s3:HeadBucket (larger effort) as a follow-up.
Testing
Local testing
make debugsucceeded: yesInteg tests succeeded: yes
New tests cover the changes: no
Description for the changelog
Fix init process s3 getBucketLocation issue for eu-west-1 region
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.