Skip to content

Fix/openssl connect close socket on error #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Fix/openssl connect close socket on error #1939

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b430b7
Fix: Close socket on error in Openssl_Connect to prevent file descrip…
YOSI-yoshidayuji Apr 7, 2025
a041404
For safety, change the initial value of socketStatus to an error.
YOSI-yoshidayuji Apr 7, 2025
de64764
Minor formatting
aggarg Apr 8, 2025
0621ce4
Fix formatting check
aggarg Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion platform/posix/transport/src/openssl_posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ OpensslStatus_t Openssl_Connect( NetworkContext_t * pNetworkContext,
uint32_t recvTimeoutMs )
{
OpensslParams_t * pOpensslParams = NULL;
SocketStatus_t socketStatus = SOCKETS_SUCCESS;
SocketStatus_t socketStatus = SOCKETS_CONNECT_FAILURE;
OpensslStatus_t returnStatus = OPENSSL_SUCCESS;
int32_t sslStatus = 0;
uint8_t sslObjectCreated = 0;
Expand Down Expand Up @@ -694,6 +694,11 @@ OpensslStatus_t Openssl_Connect( NetworkContext_t * pNetworkContext,
if( returnStatus != OPENSSL_SUCCESS )
{
LogError( ( "Failed to establish a TLS connection." ) );

if( socketStatus == SOCKETS_SUCCESS )
{
Sockets_Disconnect( pOpensslParams->socketDescriptor );
}
}
else
{
Expand Down