Skip to content

misc: upgrade to Gradle 9.0.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

misc: upgrade to Gradle 9.0.0 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bc0be4
Upgrade to Gradle 9.0.0
lauzadis Aug 14, 2025
7a1925f
Leave a comment
lauzadis Aug 14, 2025
9115bb1
Fix creation of duplicate `runtimeClasspath` configuration
lauzadis Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-plugins/smithy-build/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ repositories {
dependencies {
implementation(libs.smithy.model)
implementation(libs.smithy.gradle.base.plugin)
testImplementation(libs.junit.jupiter)
testImplementation(kotlin("test"))
Copy link
Contributor

@0marperez 0marperez Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use Kotlin's test instead of Jupiter regardless but was this because of the Gradle upgrade?

Copy link
Member Author

@lauzadis lauzadis Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was

}

gradlePlugin {
Expand Down
1 change: 0 additions & 1 deletion ...d-plugins/smithy-build/src/main/kotlin/aws/sdk/kotlin/gradle/codegen/SmithyBuildPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ class SmithyBuildPlugin : Plugin<Project> {
listOf(
"smithyCli",
"smithyBuild",
"runtimeClasspath",
Copy link
Contributor

@0marperez 0marperez Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removal due to the Gradle upgrade or just cleanup?

Copy link
Member Author

@lauzadis lauzadis Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was, the commit message has the exception I was seeing when trying to build aws-sdk-kotlin: 9115bb1

Copy link
Contributor

@0marperez 0marperez Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, but it doesn't break anything when we remove it? I'm guessing that it was there for a reason

Copy link
Member Author

@lauzadis lauzadis Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing broke locally

).map(configurations::maybeCreate)

tasks.register<SmithyBuildTask>(TASK_GENERATE_SMITHY_PROJECTIONS) {
Expand Down
7 changes: 3 additions & 4 deletions ...smithy-build/src/test/kotlin/aws/sdk/kotlin/gradle/codegen/GenerateSmithyBuildTaskTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ import aws.sdk.kotlin.gradle.codegen.tasks.GenerateSmithyBuild
import aws.sdk.kotlin.gradle.codegen.tasks.json
import org.gradle.kotlin.dsl.create
import org.gradle.testfixtures.ProjectBuilder
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Test
import software.amazon.smithy.model.node.Node
import java.io.*
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertTrue

class GenerateSmithyBuildTaskTest {
@Test
Expand Down
3 changes: 3 additions & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
kotlin.code.style=official

# TODO Remove once configuration cache is enabled by default
Copy link
Contributor

@0marperez 0marperez Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would that be?

Copy link
Member Author

@lauzadis lauzadis Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue

org.gradle.configuration-cache=true
Copy link
Contributor

@0marperez 0marperez Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at the documentation for 8.14.2 and it's not enabled by default. Why do we want to start using it now?

This feature is not enabled by default

Copy link
Member Author

@lauzadis lauzadis Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a new feature that improves build speed and has no downside

2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https://services.gradle.org/distributions/gradle-8.14.2-bin.zip
distributionUrl=https://services.gradle.org/distributions/gradle-9.0.0-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading