feat: plannedRemoval ktlint rule #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
commented
Sep 19, 2025
| @@ -43,7 +43,7 @@ class DeprecatedApiRule : Rule(RuleId("minor-version-strategy-rules:deprecated-a | |||
| emit( | |||
| node.startOffset, | |||
| "The deprecated API is scheduled for removal, please remove it before releasing the next minor version.", | |||
| true, | |||
| false, | |||
Contributor
Author
There was a problem hiding this comment.
This is to indicate if the rule can be auto-corrected. It should've been false from the beginning.
lauzadis
reviewed
Sep 19, 2025
gradle/libs.versions.toml
Outdated
| smithy-gradle-plugin-version = "1.3.0" | ||
| junit-version = "5.10.1" | ||
| coroutines-version = "1.10.2" | ||
| slf4j = "2.0.17" |
| import com.pinterest.ktlint.rule.engine.core.api.RuleSetId | ||
|
|
||
| class MinorVersionRuleSetProvider : RuleSetProviderV3(RuleSetId("minor-version-strategy-rules")) { | ||
| internal const val RULE_SET = "minor-version-strategy-rules" |
Member
There was a problem hiding this comment.
Can you explain this RULE_SET refactor?
Contributor
Author
There was a problem hiding this comment.
Do you mean the MinorVersionRuleSetProvider one or in general?
Member
There was a problem hiding this comment.
In general, why do we need it?
Contributor
Author
There was a problem hiding this comment.
Every rule ID needs to have a rule-set ID followed by : and then the name of the rule. This is just to stop repeating the rule-set ID so many times.
ianbotsf
approved these changes
Sep 19, 2025
lauzadis
approved these changes
Sep 19, 2025
0marperez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
@PlannedRemovalis always accompanied by@DeprecatedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.