feat: automatic repo tools version bumps #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
requested changes
Nov 18, 2025
.github/workflows/run-release.yml
Outdated
| type: boolean | ||
| required: false | ||
| default: false | ||
| description: 'Whether to create an CRT Kotlin version bump pull request for this release' |
.github/workflows/run-release.yml
Outdated
|
|
||
| - name: AWS SDK Kotlin pull request | ||
| if: ${{ inputs.sdk-version-bump == 'true' }} | ||
| uses: aws/aws-kotlin-repo-tools/.github/actions/version-bump-pr@main |
Contributor
There was a problem hiding this comment.
Nit: We should use the syntax for actions in the same repository:
uses: ./.github/actions/version-bump-pr
.github/workflows/run-release.yml
Outdated
Comment on lines
38
to
48
| if [ "${{ inputs.kn-release }}" == "true" ]; then | ||
| CURRENT_VERSION=$(git tag --sort=-creatordate | grep -- '-kn$' | head -n 1) | ||
| else | ||
| CURRENT_VERSION=$(git tag --sort=-creatordate | grep -v -- '-kn$' | head -n 1) | ||
| fi | ||
| CURRENT_VERSION=$(git tag --sort=-creatordate | grep -- '-kn$' | head -n 1) |
Contributor
There was a problem hiding this comment.
Correctness: This retains the old logic for determining the previous K/N version number, which is not what we want. Since we're not cutting -kn releases anymore, we should probably just remove the grep filter altogether:
CURRENT_VERSION=$(git tag --sort=-creatordate | head -n1)
.github/workflows/run-release.yml
Outdated
Comment on lines
102
to
107
| - name: Delete failed release tag | ||
| if: ${{ failure() }} | ||
| run: | | ||
| git push --delete origin ${{ steps.resolve-new-version.outputs.NEW_VERSION }} | ||
| if [ "${{ steps.release-job.outcome }}" != "success" ]; then | ||
| git push --delete origin ${{ steps.resolve-new-version.outputs.NEW_VERSION }} | ||
| fi |
Contributor
There was a problem hiding this comment.
Nit: Move the bash if up into the step if: by using failure with conditions:
- name: Delete failed release tag
if: ${{ failure() && steps.release-job.outcome != 'success' }}
run: |
git push --delete origin ${{ steps.resolve-new-version.outputs.NEW_VERSION }}
Comment on lines
35
to
36
| git branch $BRANCH | ||
| git checkout $BRANCH |
Contributor
There was a problem hiding this comment.
Nit: Can be simplified:
git checkout -b $BRANCH
Comment on lines
25
to
53
| - name: Create pull request | ||
| shell: bash | ||
| env: | ||
| REPO: ${{ inputs.repo }} | ||
| NEW_VERSION: ${{ inputs.version }} | ||
| GH_TOKEN: ${{ inputs.pat }} | ||
| run: | | ||
| BRANCH=repo-tools-$NEW_VERSION | ||
| cd $REPO | ||
| git branch $BRANCH | ||
| git checkout $BRANCH | ||
| git config user.name aws-sdk-kotlin-ci | ||
| git config user.email "[email protected]" | ||
| sed -i "s/aws-kotlin-repo-tools-version = .*/aws-kotlin-repo-tools-version = \"$NEW_VERSION\"/" gradle/libs.versions.toml | ||
| git add gradle/libs.versions.toml | ||
| git commit -m "misc: repo tools v$NEW_VERSION" | ||
| git push --force --set-upstream origin $BRANCH | ||
| EXISTING_PR=$(gh pr list --head "$BRANCH" --state open --json number -q '.[0].number') | ||
| if [ -z "$EXISTING_PR" ]; then | ||
| PR_URL=$(gh pr create --title "misc: repo tools v$NEW_VERSION" --body "Bumps repo tools to v$NEW_VERSION") | ||
| PR_NUMBER=$(basename $PR_URL) | ||
| gh pr edit $PR_NUMBER --add-label "no-changelog" | ||
| fi |
Contributor
There was a problem hiding this comment.
Suggestion: It would be nice to see some logs from this action which could assist in debugging. Offhand, I might suggest dumping the libs.versions.toml file after modification, showing the URLs to the new or existing PRs, emitting a warning when the user checked the box for a repo but that repo already has an open PR, etc.
ianbotsf
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Allows us to create repo tools version bumps in downstream repos via our release workflow.
Example PRs:
aws/aws-sdk-kotlin#1734
aws/aws-sdk-kotlin#1734
aws/aws-crt-kotlin#210
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.