Skip to content

Conversation

@lauzadis
Copy link
Member

@lauzadis lauzadis commented Nov 20, 2024

Issue #, if available:
Closes #49

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines 80 to 81
val githubOrganization = if (repoName.equals("smithy-kotlin", ignoreCase = true)) "smithy-lang" else "awslabs"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: This seems like the wrong location for the logic. Can't we just parameterize githubOrganization the same way we already do repoName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@lauzadis lauzadis requested a review from ianbotsf November 20, 2024 19:26
@lauzadis lauzadis merged commit 2090268 into main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix references to awslabs/smithy-kotlin

3 participants