Skip to content

chore: install the kat tool in a dedicated home directory instead of using $PWD #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

chore: install the kat tool in a dedicated home directory instead of using $PWD #72

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc81f85
chore: install the kat tool in a dedicated home directory instead of …
ianbotsf Mar 7, 2025
1e31d1a
`pushd` → `cd`
ianbotsf Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/actions/setup-kat/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,22 @@ runs:
echo "No versions of kat were found"
exit 1
fi
echo "Downloading kat version $kat_version to $PWD"


kat_dir="$HOME/kat"

echo "Creating directory for kat tool at $kat_dir"
mkdir -p "$kat_dir"
pushd "$kat_dir"
Copy link
Contributor

@0marperez 0marperez Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why pushd instead of cd?

Copy link
Contributor Author

@ianbotsf ianbotsf Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh force of habit. In this case I could just use cd instead since I'm not using popd.


echo "Downloading kat version $kat_version to $kat_dir"
aws s3 cp s3://kotlin-sdk-build-tools/kat-releases/$kat_version/kat-$kat_version.zip ./kat.zip --no-progress

echo "Unzipping kat tool"
unzip -qq ./kat.zip -d kat
unzip -qq ./kat.zip

kat_binary_path="$PWD/kat/kat-$kat_version/bin"
kat_binary_path="$kat_dir/kat-$kat_version/bin"
echo "Appending \"$kat_binary_path\" to path"
export PATH="$kat_binary_path:$PATH"
echo "$kat_binary_path" >> $GITHUB_PATH

echo "Installed kat version $(kat version)" || (echo "Failed to execute kat command" && exit 1)
echo "Installed kat version $(kat version)" || (echo "Failed to execute kat command" && exit 1)