Skip to content

fix: intellij collectDelegatedArtifactSizeMetrics issue #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix: intellij collectDelegatedArtifactSizeMetrics issue #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build-plugins/build-support/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ dependencies {

implementation(libs.nexusPublishPlugin)
compileOnly(gradleApi())
implementation("aws.sdk.kotlin:s3:1.1.+")
implementation("aws.sdk.kotlin:cloudwatch:1.1.+")
implementation("aws.sdk.kotlin:s3:1.4.+")
implementation("aws.sdk.kotlin:cloudwatch:1.4.+")
testImplementation(libs.junit.jupiter)
}

Expand Down
16 changes: 8 additions & 8 deletions .../aws/sdk/kotlin/gradle/plugins/artifactsizemetrics/CollectDelegatedArtifactSizeMetrics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,18 @@ internal abstract class CollectDelegatedArtifactSizeMetrics : DefaultTask() {
private fun getFiles(keys: List<String>): List<String> = runBlocking {
S3Client.fromEnvironment().use { s3 ->
keys.map { key ->
async { s3.getObjectAsText(key) }
async {
s3.getObject(
GetObjectRequest {
bucket = S3_ARTIFACT_SIZE_METRICS_BUCKET
this.key = key
},
) { it.body?.decodeToString() ?: throw AwsSdkGradleException("Metrics file $key is missing a body") }
}
}.awaitAll()
}
}

private suspend fun S3Client.getObjectAsText(objectKey: String) = getObject(
GetObjectRequest {
bucket = S3_ARTIFACT_SIZE_METRICS_BUCKET
key = objectKey
},
) { it.body?.decodeToString() ?: throw AwsSdkGradleException("Metrics file $objectKey is missing a body") }

private fun combine(metricsFiles: List<String>) = buildString {
appendLine("Artifact, Size")
metricsFiles.forEach { metricsFile ->
Expand Down