feat: add python option for creating parent packages during copy #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
reedham-aws
reviewed
Aug 4, 2025
|
There's also a few test failures related to the change, should be small change to fix it seems. |
I believe I found a fix and will push that up shortly. |
joeyhage
force-pushed
the
feature/python-packaging
branch
4 times, most recently
from
7dcfd82 to
30b58f3
Compare
reedham-aws
previously approved these changes
Aug 4, 2025
joeyhage
force-pushed
the
feature/python-packaging
branch
from
30b58f3 to
34dd0c7
Compare
reedham-aws
approved these changes
Aug 5, 2025
|
@reedham-aws Following up to see what is needed from me now to contribute this code. Thanks! |
|
We need two reviewers to approve, I will talk to the team about getting another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws/aws-sam-cli#6593
Description of changes:
This change introduces a configuration option for the python lambda directory structure. I previously created a wrapper around sam cli to achieve this but would like to contribute the feature back to this project. The issue linked above and my GitHub repo have examples and documentation that explain the goal of this change. Once implemented, I will need to submit a PR for aws-sam-cli as well to utilize this new optional config.
I welcome your criticism and suggestions; thank you for your time reviewing this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.