Skip to content

Consolidate agreement functions into LcPtr<EVP_PKEY> #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 6, 2025

Description of changes:

We previously had two nearly identical methods for performing agreement. This change consolidates them into an agree function in LcPtr<EVP_PKEY>

Testing:

No changes to tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 6, 2025 19:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.35%. Comparing base (c358484) to head (5aaa88f).
⚠️ Report is 239 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/evp_pkey.rs 76.19% 4 Missing and 1 partial ⚠️
aws-lc-rs/src/agreement.rs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   95.80%   92.35%   -3.45%     
==========================================
  Files          61       71      +10     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8568     +767     
- Misses        342      429      +87     
- Partials        0      280     +280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth requested a review from skmcgrail August 7, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants