Fix issues in pass_util.cc password handling#3032
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
==========================================
+ Coverage 78.35% 78.51% +0.16%
==========================================
Files 689 689
Lines 121010 121014 +4
Branches 16992 16995 +3
==========================================
+ Hits 94813 95016 +203
+ Misses 25302 25099 -203
- Partials 895 899 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Addresses multiple issues in
tool-openssl/pass_util.ccand thePasswordclass:fd:parsing to usestrtoulinstead ofatoi, avoiding undefined behavior on overflow.pass:passwords, matching OpenSSL behavior.pass:andenv:sources.same_fileinitialization.Call-outs:
pass:a:bwas previously rejected and now succeeds with passworda:b.Password::secure_clear()now cleanses up tocapacity()bytes, which is technically beyond thestd::stringstandard contract but safe across all major implementations.Testing:
All existing
PassUtilTesttests pass. UpdatedDirectPasswordEdgeCasesto cover passwords containing colons.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.