fix: awscli arch is hardcoded (aarch64 broken)#370
Open
khannz wants to merge 1 commit intoaws:v2.8.1from
Open
Conversation
|
Good tip, but this PR changes more than just fetching the correct architecture, and those changes aren't necessary:
All you need to do to fetch the correct curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o $zip_fileto: curl "https://awscli.amazonaws.com/awscli-exe-linux-$(uname -m).zip" -o $zip_fileYou (or anyone else) are more than welcome to take this change for your own PR 😄 |
FYI, looks like #332 does this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #358
Description of changes: Using standard way to detect ID of system architecture (
uname -m), fix hardcodedx86_64ID, which is not working for ARM architectures.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.