FIX: package-requirements always returns exit code 0, even on failure#389
Open
mattbarreiro wants to merge 1 commit intoaws:v2.9.2from
Open
FIX: package-requirements always returns exit code 0, even on failure#389mattbarreiro wants to merge 1 commit intoaws:v2.9.2from
package-requirements always returns exit code 0, even on failure#389mattbarreiro wants to merge 1 commit intoaws:v2.9.2from
Conversation
…n pip3 download failure
Author
|
Hi - would someone kindly take a look at this? Thank you in advanced! |
Author
|
Hi - any chance of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #:
Closes #388
Description of changes:
Check the exit code for
pip3 download -r ...inentrypoint.sh. If non-zero, exit with the same error code.Note: This only solves one particular case. A more thorough solution would be to use something like
set -efor all these "utility" commands (package-requirements,test-startup-script, etc). But I imagine that is a larger (and possibly internal) discussion.If this change is accepted, I also request that it get merged to all lower environments (or at least all supported ones) as well. This bug exists in v2.2.2-v2.9.2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.