Skip to content

Update readme to add windows 2019 deprecation notice #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Update readme to add windows 2019 deprecation notice #1193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86efbe7
Add windows 2019 deprecation notice in readme
tanmaysankhe Sep 15, 2025
071fa14
Merge pull request #1 from tanmaysankhe/tsankhe-readme
tanmaysankhe Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ The aws-node-termination-handler **Queue Processor** will monitor an SQS queue o

You can run the termination handler on any Kubernetes cluster running on AWS, including self-managed clusters and those created with Amazon [Elastic Kubernetes Service](https://docs.aws.amazon.com/eks/latest/userguide/what-is-eks.html). If you're using [EKS managed node groups](https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html), you don't need the aws-node-termination-handler.

> Notice: Windows Server 2019 support has been removed to align with GitHub's deprecation schedule (end date: June 30, 2025). You can continue using other supported Windows versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we also need to include the GitHub link for GitHub Actions windows deprecation this one so that customers can view the actual issue - Deprecation.

Instead of Notice: have it like a Note with symbol as this is related to deprecation something like this with ⚠️ Note
Also mention GitHub Actions do not support windows 2019 anymore.

Do not mention other supported windows versions. This is not related to all the windows versions we have windows 2019 and 2022 in our Github Actions workflows, you can suggest them to shift to windows 2022.

## Major Features

Both modes (IMDS and Queue Processor) monitor for events affecting your EC2 instances, but each supports different types of events. Both modes have the following:
Expand Down Expand Up @@ -699,4 +701,4 @@ In IMDS mode, metrics can be collected as follows:
Contributions are welcome! Please read our [guidelines](https://github.com/aws/aws-node-termination-handler/blob/main/CONTRIBUTING.md) and our [Code of Conduct](https://github.com/aws/aws-node-termination-handler/blob/main/CODE_OF_CONDUCT.md)

## License
This project is licensed under the Apache-2.0 License.
This project is licensed under the Apache-2.0 License.