Fix system test config for efa, remove duplicate test in intel_mpi, tag ptrace control with 'config'

Author: dreambeyondorange

kitchen.resources-config.yml

@@ -30,7 +30,7 @@ suites:
       - recipe[aws-parallelcluster-common::test_resource]
     verifier:
       controls:
-        - efa_debian_system_settings_configured
+        - tag:config_efa_debian_system_settings_configured
     attributes:
       resource: efa:configure
       cluster:
@@ -44,7 +44,7 @@ suites:
       - recipe[aws-parallelcluster-common::test_resource]
     verifier:
       controls:
-        - efa_debian_system_settings_configured
+        - tag:config_efa_debian_system_settings_configured
     attributes:
       resource: efa:configure
       cluster:

kitchen.validate-config.yml

@@ -17,7 +17,7 @@ _common_cluster_attributes: &_common_cluster_attributes
   custom_node_package: <%= ENV['PARALLELCLUSTER_NODE_URL'] %>
   dcv_enabled: 'head_node'
   dcv_port: '8443'
-  enable_efa: 'compute'
+  enable_efa: 'efa'
   nvidia:
     enabled: <%= ENV['NVIDIA_ENABLED'] %>
 

test/recipes/controls/aws_parallelcluster_install/intel_mpi_spec.rb

@@ -21,13 +21,3 @@
     its('stdout') { should match(/Version #{node['cluster']['intelmpi']['version'].split('.')[0..1].join(".")}/) }
   end
 end
-
-control 'tag:config_intel_mpi_ptrace_protection_configured_on_ubuntu1804' do
-  only_if { node['conditions']['intel_mpi_supported'] && os_properties.ubuntu1804? }
-
-  ptrace_scope = instance.head_node? ? 1 : 0
-  describe 'check ptrace protection enabled' do
-    subject { bash("sudo -u #{node['cluster']['cluster_user']} sysctl kernel.yama.ptrace_scope") }
-    its('stdout') { should match /kernel.yama.ptrace_scope = #{ptrace_scope}/ }
-  end
-end

test/resources/controls/aws_parallelcluster_config/efa_spec.rb

@@ -1,4 +1,4 @@
-control 'efa_debian_system_settings_configured' do
+control 'tag:config_efa_debian_system_settings_configured' do
   title 'Check debian system is correctly configured for EFA'
 
   only_if { os.debian? && !os_properties.virtualized? }