Skip to content

Conversation

@hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Oct 9, 2024

Description of changes

  • Missed certificate configurations from 3.10

References

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe hgreebe marked this pull request as ready for review October 9, 2024 18:44
@hgreebe hgreebe requested review from a team as code owners October 9, 2024 18:44
hanwen-pcluste
hanwen-pcluste previously approved these changes Oct 9, 2024
hanwen-pcluste
hanwen-pcluste previously approved these changes Oct 10, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-3.11@a38b423). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-3.11    #2815   +/-   ##
===============================================
  Coverage                ?   76.67%           
===============================================
  Files                   ?       22           
  Lines                   ?     2242           
  Branches                ?        0           
===============================================
  Hits                    ?     1719           
  Misses                  ?      523           
  Partials                ?        0           
Flag Coverage Δ
unittests 76.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hgreebe hgreebe merged commit 45a38f2 into aws:release-3.11 Oct 16, 2024
30 of 32 checks passed
hgreebe added a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Oct 30, 2024
* Update yum deps for ADC

* Fix cloudwatch key url domain for ADC

* [ADC] Set default node package for build image command

* [ADC] Configure certificates for compute fleet manager

* [ADC Build Image] Source AWS_CA_BUNDLE during build

* [ADC] Configure certificates for login nodes in ADC
hgreebe added a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Nov 25, 2024
* Update yum deps for ADC

* Fix cloudwatch key url domain for ADC

* [ADC] Set default node package for build image command

* [ADC] Configure certificates for compute fleet manager

* [ADC Build Image] Source AWS_CA_BUNDLE during build

* [ADC] Configure certificates for login nodes in ADC
hgreebe added a commit that referenced this pull request Dec 2, 2024
* Update yum deps for ADC

* Fix cloudwatch key url domain for ADC

* [ADC] Set default node package for build image command

* [ADC] Configure certificates for compute fleet manager

* [ADC Build Image] Source AWS_CA_BUNDLE during build

* [ADC] Configure certificates for login nodes in ADC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants