Upgrade python version to 3.12 for all OSs except AL2 #2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2869 +/- ##
========================================
Coverage 76.63% 76.63%
========================================
Files 22 22
Lines 2243 2243
========================================
Hits 1719 1719
Misses 524 524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hgreebe
force-pushed
the
develop
branch
4 times, most recently
from
99f1c3c to
c767534
Compare
Comment on lines
43
to
57
| set -e | ||
| tar xzf cookbook-dependencies.tgz | ||
| cd dependencies | ||
| #{virtualenv_path}/bin/pip install * -f ./ --no-index | ||
| #{virtualenv_path}/bin/pip install -r requirements.txt | ||
| if [ $? -ne 0 ]; then | ||
| tar xzf cookbook-dependencies.tgz | ||
| cd dependencies | ||
| #{virtualenv_path}/bin/pip install * -f ./ --no-index | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
Just so that there is a fall back option
Comment on lines
42
to
46
| cookbook_file "#{cookbook_virtualenv_path}/requirements.txt" do | ||
| source "cookbook_virtualenv/requirements.txt" | ||
| mode '0755' | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
to facilitate the change above
hanwen-cluster
previously approved these changes
Feb 20, 2025
…ccesary python dep installation
hanwen-cluster
approved these changes
Feb 20, 2025
himani2411
pushed a commit
to himani2411/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 21, 2025
himani2411
pushed a commit
to himani2411/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 21, 2025
himani2411
added a commit
that referenced
this pull request
Feb 21, 2025
* Revert "[Test] Fix Python version in kitchen tests related to AWS Batch and CFN Boostrap scripts. In particular, we expect all Oses to use Python 3.12.8, except for AL2 which uses 3.9.20." This reverts commit 4574ee5. * Revert "Upgrade python version to 3.12 for all OSs except AL2 and remove unneccesary python dep installation (#2869)" This reverts commit 45431e6. --------- Co-authored-by: Himani Anil Deshpande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.