Download http-parser from s3 #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgreebe
force-pushed
the
release-3.12
branch
3 times, most recently
from
2181442 to
8e631c5
Compare
| REPO_DEFINITION | ||
|
|
||
| yum --disablerepo="*" --enablerepo="amzn2-iso" install -y "*-${REGION}" | ||
| yum --disablerepo="*" --enablerepo="${OS}-iso" install -y "*-${REGION}" |
Contributor
There was a problem hiding this comment.
Why is this command only necessary on amzn2?
Contributor
Author
There was a problem hiding this comment.
Because for amzn2023 we do dnf install -y amazon-linux-repo-iso ca-certificates-isob which is what is in the documentation. But I kept what we do for amzn2 the same, so that is why they install the region-specific packages differently
Comment on lines
-52
to
+79
| for user in "${USERS[@]}"; do | ||
| echo "[INFO] Setting CA bundle ${CA_BUNDLE} for user ${user}" | ||
| sudo mkhomedir_helper $user | ||
| sudo -u $user aws configure set ca_bundle "$CA_BUNDLE" | ||
| done | ||
| sudo aws configure set ca_bundle "$CA_BUNDLE" |
Contributor
Author
There was a problem hiding this comment.
Because setting the system wide environment variables make them apply for each user, so it is unneccessary to loop through each user
hanwen-cluster
approved these changes
Feb 5, 2025
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.