Skip to content

Set instance id and instance type in Slurm #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Set instance id and instance type in Slurm #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
- Upgrade Pmix to 5.0.6 (from 5.0.3).
- Upgrade ARM PL to version 24.10 (from 23.10).
- Remove generation of DSA keys for login nodes as DSA, which became unsupported in OpenSSH 9.7+.
- Set instance ID and instance type information in Slurm upon compute nodes launch.

3.12.0
------
Expand Down
6 changes: 5 additions & 1 deletion cookbooks/aws-parallelcluster-slurm/spec/unit/recipes/config_slurmd_systemd_service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
for_all_oses do |platform, version|
context "on #{platform}#{version}" do
cached(:chef_run) do
runner(platform: platform, version: version).converge(described_recipe)
runner = runner(platform: platform, version: version) do |node|
node.override['ec2']['instance_id'] = "i-xxx"
node.override['ec2']['instance_type'] = "fake-instance-type"
end
runner.converge(described_recipe)
end

it 'creates the service definition for slurmd' do
Expand Down
2 changes: 1 addition & 1 deletion cookbooks/aws-parallelcluster-slurm/templates/default/slurm/compute/slurmd.service.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ConditionPathExists=<%= node['cluster']['slurm']['install_dir'] %>/etc/slurm.con
[Service]
Type=simple
EnvironmentFile=-/etc/sysconfig/slurmd
ExecStart=<%= node['cluster']['slurm']['install_dir'] %>/sbin/slurmd -D -s $SLURMD_OPTIONS
ExecStart=<%= node['cluster']['slurm']['install_dir'] %>/sbin/slurmd -D -s $SLURMD_OPTIONS --instance-id <%= node['ec2']['instance_id'] %> --instance-type <%= node['ec2']['instance_type'] %>
ExecReload=/bin/kill -HUP $MAINPID
KillMode=process
LimitNOFILE=131072
Expand Down
Loading