Skip to content

Conversation

@hanwen-cluster
Copy link
Contributor

@hanwen-cluster hanwen-cluster commented Mar 13, 2025

This commit saves time because the os won't retry on unsupported ipv6 and optional Internet connection

Job start time on Rocky is shorten from 8.5 mins to 7 mins

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hanwen-cluster hanwen-cluster marked this pull request as ready for review March 13, 2025 19:55
@hanwen-cluster hanwen-cluster requested review from a team as code owners March 13, 2025 19:55
@hanwen-cluster hanwen-cluster force-pushed the release-3.13 branch 2 times, most recently from 06fb8cb to ac43384 Compare March 14, 2025 17:45
@hanwen-cluster hanwen-cluster changed the title Shortening RHEL/Rock boot time by disabling ipv6 and internet check Shortening RHEL/Rock boot time by deprioritizing ipv6 and disable internet check Mar 14, 2025
mode '0644'
end

# Disable ipv6 IMDS in cloud init to speed up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can we add unit tests in a separate PR?

@gmarciani
Copy link
Contributor

gmarciani commented Mar 14, 2025

LGTm since we are disabling IMDs IPv6 only for cloudinit and there are no users actually using pcluster in IPV6 mode.

Can you please capture the change in the changelog?

…ernet check

This commit saves time because the os won't retry on unsupported ipv6 and optional Internet connection

Signed-off-by: Hanwen <[email protected]>
@hanwen-cluster
Copy link
Contributor Author

Added changelog.
Can we work on unit tests in another PR?

@hanwen-cluster hanwen-cluster enabled auto-merge (rebase) March 14, 2025 20:17
@hanwen-cluster hanwen-cluster merged commit 52fae13 into aws:release-3.13 Mar 14, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants