Skip to content

Conversation

@himani2411
Copy link
Contributor

Description of changes

  • Remove UnkillableStepTimeout as slurm sets this value as 5 *MessageTimeout

Tests

  • Simple cluster creation and a job submission

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hehe7318
hehe7318 previously approved these changes Mar 18, 2025
@gmarciani
Copy link
Contributor

We should add an entry in the changelog to surface this change

@himani2411 himani2411 enabled auto-merge (squash) March 19, 2025 01:00
@himani2411 himani2411 merged commit 4bdeb90 into aws:develop Apr 2, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants