Skip to content

Conversation

@gmarciani
Copy link
Contributor

@gmarciani gmarciani commented May 13, 2025

Description of changes

Fix a bug in the installation of GCC required by ARM Performance Library to cover both gcc 9.3 and gcc 11.3.
In particular gcc 9.3.0 requires ftp endpoint, whereas gcc 11.3.0 requires http endpoint.

The regression was introduced by #2942, where we replace only http endpoint (gcc-11.3), while we should cover both ftp (gcc-9.3) and http (gcc-11.3).

Tests

Build image succeeded on both AL2 (using gcc9.3) and AL23 (using gcc11.3)
ARMPL installation succeeds on both AL2 and AL23 and verified from logs that gcc dependencioes are fetched from our public buckets both when using gcc9.3 and gcc11.3.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani force-pushed the wip/mgiacomo/3131/fix-armpl-installation-0512-2 branch from 1bf682f to 5ba11e6 Compare May 13, 2025 20:29
@gmarciani gmarciani marked this pull request as ready for review May 14, 2025 14:43
@gmarciani gmarciani requested review from a team as code owners May 14, 2025 14:43
…nce Library to cover both gcc 9.3 and gcc 11.3. In particular gcc 9.3.0 requires ftp endpoint, whereas gcc 11.3.0 requires http endpoint.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3131/fix-armpl-installation-0512-2 branch from 5ba11e6 to f3b84a2 Compare May 14, 2025 14:45
@gmarciani gmarciani added the 3.x label May 14, 2025
@gmarciani gmarciani enabled auto-merge (rebase) May 14, 2025 14:48
@gmarciani gmarciani merged commit 47d9a1c into aws:release-3.13 May 14, 2025
31 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants