[release-3.13] Give systemctl poweroff --force the sudoer permission
#2959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… self termination issue
gmarciani
reviewed
May 27, 2025
| Cmnd_Alias SLURM_COMMANDS = <%= node['cluster']['slurm']['install_dir'] %>/bin/scontrol, <%= node['cluster']['slurm']['install_dir'] %>/bin/sinfo | ||
| Cmnd_Alias SLURM_HOOKS_COMMANDS = <%= node_virtualenv_path %>/bin/slurm_suspend, <%= node_virtualenv_path %>/bin/slurm_resume, <%= node_virtualenv_path %>/bin/slurm_fleet_status_manager | ||
| Cmnd_Alias SHUTDOWN = /usr/sbin/shutdown | ||
| Cmnd_Alias SYSTEMCTL_POWEROFF = /usr/bin/systemctl poweroff --force |
Contributor
There was a problem hiding this comment.
I have verified that there is no risk for privilege escalation, i.e. the user can only execute the precisely specified command, cannot even add extra options.
So the change is safe from a security standpoint.
gmarciani
reviewed
May 27, 2025
| Cmnd_Alias SLURM_COMMANDS = <%= node['cluster']['slurm']['install_dir'] %>/bin/scontrol, <%= node['cluster']['slurm']['install_dir'] %>/bin/sinfo | ||
| Cmnd_Alias SLURM_HOOKS_COMMANDS = <%= node_virtualenv_path %>/bin/slurm_suspend, <%= node_virtualenv_path %>/bin/slurm_resume, <%= node_virtualenv_path %>/bin/slurm_fleet_status_manager | ||
| Cmnd_Alias SHUTDOWN = /usr/sbin/shutdown | ||
| Cmnd_Alias SYSTEMCTL_POWEROFF = /usr/bin/systemctl poweroff --force |
Contributor
There was a problem hiding this comment.
The respective test must be adapted. I will add it in a dedicated PR
gmarciani
approved these changes
May 27, 2025
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
systemctl poweroff --forcethe sudoer permission to fix the ubuntu24 self termination issueChecklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.