-
Notifications
You must be signed in to change notification settings - Fork 109
[Subnet Prioritization] Add EnableSingleAvailabilityZone to Fleet Config #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
| } | ||
| }, | ||
| CriticalError, | ||
| "Unable to find key 'EnableSingleAvailabilityZone' in the configuration file. Queue: q1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to showcase this error if Customer doesn't provide this parameter as this is not required parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is a test case but we want to cover the case where we don't see this error and fleet-config.json gets created even if this parameter is not provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this fleet-config.json is what drives the scaling through node package
…ingleAvailabilityZone is not provided Signed-off-by: Hanxuan Zhang <[email protected]>
|
Closing as we are not supporting this paramter. |
|
|
||
| **CHANGES** | ||
| - Ubuntu 20.04 is no longer supported. | ||
| - Add SingleAvailabilityZone parameter to fleet_config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entries must be more focus on the user experience than on the implementation details. A user does not care about where we inject the new parameter, but on the consequences of enabling it.
| ), | ||
| ( | ||
| { | ||
| "Scheduling": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Tests] what's the goal of adding this test case?
Description of changes
Add EnableSingleAvailabilityZone parameter to fleet_config.json
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.