[Subnet Prioritization] Add EnableSingleAvailabilityZone to Fleet Config #2973
Conversation
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
Signed-off-by: Hanxuan Zhang <[email protected]>
| } | ||
| }, | ||
| CriticalError, | ||
| "Unable to find key 'EnableSingleAvailabilityZone' in the configuration file. Queue: q1", |
There was a problem hiding this comment.
We don't want to showcase this error if Customer doesn't provide this parameter as this is not required parameter.
There was a problem hiding this comment.
I understand this is a test case but we want to cover the case where we don't see this error and fleet-config.json gets created even if this parameter is not provided.
There was a problem hiding this comment.
As this fleet-config.json is what drives the scaling through node package
…ingleAvailabilityZone is not provided Signed-off-by: Hanxuan Zhang <[email protected]>
|
Closing as we are not supporting this paramter. |
|
|
||
| **CHANGES** | ||
| - Ubuntu 20.04 is no longer supported. | ||
| - Add SingleAvailabilityZone parameter to fleet_config.json |
There was a problem hiding this comment.
Changelog entries must be more focus on the user experience than on the implementation details. A user does not care about where we inject the new parameter, but on the consequences of enabling it.
| ), | ||
| ( | ||
| { | ||
| "Scheduling": { |
There was a problem hiding this comment.
[Tests] what's the goal of adding this test case?
3 participants
Description of changes
Add EnableSingleAvailabilityZone parameter to fleet_config.json
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.