Skip to content

Delete cluster name state file whenever slurm accounting is configured or updated #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

Delete cluster name state file whenever slurm accounting is configured or updated #2994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0cc721
Delete cluster name state file whenever slurm accounting is configure…
hgreebe Jul 15, 2025
baae6e7
Add spec test to cover the deletion of the cluster id state
hgreebe Jul 18, 2025
2b67150
Update changelog
hgreebe Jul 21, 2025
0eaec4c
Merge branch 'develop' into develop
hgreebe Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cookbooks/aws-parallelcluster-slurm/recipes/config/config_slurm_accounting.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@
retry_delay 10
end unless kitchen_test? || (node['cluster']['node_type'] == "ExternalSlurmDbd")

bash "Remove existing cluster name state file" do
user 'root'
group 'root'
code <<-CLUSTERSTATE
rm /var/spool/slurm.state/clustername
CLUSTERSTATE
only_if { ::File.exist?('/var/spool/slurm.state/clustername') }
Copy link
Contributor

@gmarciani gmarciani Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use bash, why using an only_if rather than having a rm -f?
Also, why using bash and not using the file resource with action delete?

end

bash "bootstrap slurm database" do
user 'root'
group 'root'
Expand Down
9 changes: 9 additions & 0 deletions cookbooks/aws-parallelcluster-slurm/recipes/update/clear_slurm_accounting.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,12 @@
supports restart: false
action %i(disable stop)
end

bash "Remove existing cluster name state file" do
Copy link
Contributor

@gmarciani gmarciani Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is duplicated. What about reducing code duplication by defining this logic into a function and call that function or use the file resources to delete the file?

user 'root'
group 'root'
code <<-CLUSTERSTATE
rm /var/spool/slurm.state/clustername
CLUSTERSTATE
only_if { ::File.exist?('/var/spool/slurm.state/clustername') }
Copy link
Contributor

@gmarciani gmarciani Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/aws/aws-parallelcluster-cookbook/pull/2994/files#r2208466853

end
Loading