Slurm accounting should not be case sensitive#3159
Open
Timothy-Wang-Arctos wants to merge 1 commit intoaws:developfrom
Open
Slurm accounting should not be case sensitive#3159Timothy-Wang-Arctos wants to merge 1 commit intoaws:developfrom
Timothy-Wang-Arctos wants to merge 1 commit intoaws:developfrom
Conversation
Prior to 3.15.0 the slurm accounting bootstrap was not case sensitive. The split from aws#3132 made it case sensitive causing the bootstrap to fail when the stack has capital letters in it. Bootstrap would fail with "Mixlib::ShellOut::ShellCommandFailed: execute[wait for cluster registration] (aws-parallelcluster-slurm::bootstrap_slurm_accounting line 20) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'" with the change to the grep command the return is the expected [0] /opt/slurm/bin/sacctmgr show clusters -Pn cluster=AL2023-Arctos format=cluster | grep -Fx AL2023-Arctos echo $? 1 /opt/slurm/bin/sacctmgr show clusters -Pn cluster=AL2023-Arctos format=cluster | grep -Fxi AL2023-Arctos al2023-arctos echo $? 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Prior to 3.15.0 the slurm accounting bootstrap was not case sensitive. The split from #3132 made it case sensitive causing the bootstrap to fail when the stack has capital letters in it.
Bootstrap would fail with
"Mixlib::ShellOut::ShellCommandFailed: execute[wait for cluster registration] (aws-parallelcluster-slurm::bootstrap_slurm_accounting line 20) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'"
with the change to the grep command the return is the expected [0]
/opt/slurm/bin/sacctmgr show clusters -Pn cluster=AL2023-Arctos format=cluster | grep -Fx AL2023-Arctos echo $?
1
/opt/slurm/bin/sacctmgr show clusters -Pn cluster=AL2023-Arctos format=cluster | grep -Fxi AL2023-Arctos al2023-arctos
echo $?
0
Tests
attempting to deploy with a stackname with uppercase letters caused fail. Rerunning with all lowercase stackname was successful
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.