Skip to content

Commit 364b54c

Browse files
Enrico Usaienrico-usai
authored andcommitted
Improve wording when blocking the update in case of managed FSx usage
Signed-off-by: Enrico Usai <[email protected]>
1 parent b14d405 commit 364b54c

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ CHANGELOG
44
2.11.9
55
-----
66

7-
**CHANGES**
8-
- Block cluster update when using a managed FSx for Lustre file system and updating VPC Security Group Id, to avoid data loss.
7+
**BUG FIXES**
8+
- Prevent updating `vpc_security_group_id` when a managed FSx for Lustre file system is configured in the cluster.
9+
Doing so would result in file system deletion and potential data loss.
910

1011
2.11.8
1112
-----

cli/src/pcluster/config/update_policy.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,11 +273,8 @@ def _check_unmanaged_fsx(_, patch):
273273
UpdatePolicy.MANAGED_FSX = UpdatePolicy(
274274
level=40,
275275
fail_reason=lambda change, patch: (
276-
"'{0}' parameter cannot be updated because the cluster was created with a managed FSx. "
277-
"The change in the '{0}' will trigger a creation of a new file system to replace the old one, "
278-
"without preserving the existing data. If you force the update you'll lose your data. "
279-
"Make sure to back up the data from the existing FSx for Lustre file system if you want to preserve them. "
280-
"For more information, see https://docs.aws.amazon.com/fsx/latest/LustreGuide/using-backups-fsx.html"
276+
"'{0}' parameter cannot be updated when a managed FSx for Lustre file system is configured. "
277+
"Do not force the update or the file system will be deleted and the cluster enter an unrecoverable state."
281278
).format(change.param_key),
282279
action_needed=lambda change, patch: (
283280
"Restore the value of parameter '{0}' to '{1}'".format(change.param_key, change.old_value)

cli/tests/pcluster/config/test_config_patch.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -488,12 +488,9 @@ def test_vpc_security_id_changes(
488488
else:
489489
check = "ACTION NEEDED"
490490
reason = (
491-
"'vpc_security_group_id' parameter cannot be updated because the cluster was created with a "
492-
"managed FSx. The change in the 'vpc_security_group_id' will trigger a creation of a new file system "
493-
"to replace the old one, without preserving the existing data. If you force the update you'll lose "
494-
"your data. Make sure to back up the data from the existing FSx for Lustre file system "
495-
"if you want to preserve them. For more information, see "
496-
"https://docs.aws.amazon.com/fsx/latest/LustreGuide/using-backups-fsx.html"
491+
"'vpc_security_group_id' parameter cannot be updated when a managed FSx for Lustre file "
492+
"system is configured. Do not force the update or the file system will be deleted "
493+
"and the cluster enter an unrecoverable state."
497494
)
498495
action_needed = (
499496
f"Restore the value of parameter 'vpc_security_group_id' to '{src_value}'"

0 commit comments

Comments
 (0)