Skip to content

Commit 88f42fb

Browse files
author
Dougal Ballantyne
committed
Fixed, improved tags and extra parameter support
1 parent fe18cff commit 88f42fb

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

cli/cfncluster/cfnconfig.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,3 +248,14 @@ def __init__(self, args):
248248
except AttributeError:
249249
pass
250250

251+
if self.args.extra_parameters is not None:
252+
try:
253+
self.parameters = dict(self.parameters)
254+
self.__temp_dict = dict(self.parameters.items() + self.args.extra_parameters.items())
255+
self.__dictlist = []
256+
for key, value in self.__temp_dict.iteritems():
257+
temp = [str(key),str(value)]
258+
self.__dictlist.append(temp)
259+
self.parameters = self.__dictlist
260+
except AttributeError:
261+
pass

cli/cfncluster/cli.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import argparse
1414
import logging
1515
import platform
16+
import json
1617

1718
import cfncluster
1819

@@ -81,9 +82,9 @@ def main():
8182
help='specify a URL for a custom cloudformation template')
8283
pcreate.add_argument("--cluster-template", "-t", type=str, dest="cluster_template", default=None,
8384
help='specify a specific cluster template to use')
84-
pcreate.add_argument("--extra-parameters", "-p", type=str, dest="extra_parameters", default=None,
85+
pcreate.add_argument("--extra-parameters", "-p", type=json.loads, dest="extra_parameters", default=None,
8586
help='add extra parameters to stack create')
86-
pcreate.add_argument("--tags", "-g", type=str, dest="tags", default=None,
87+
pcreate.add_argument("--tags", "-g", type=json.loads, dest="tags", default=None,
8788
help='tags to be added to the stack')
8889
pcreate.set_defaults(func=create)
8990

0 commit comments

Comments
 (0)