[1-click] Improvements to 1-click template for AD #6556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
added
skip-changelog-update
gmarciani
force-pushed
the
wip/mgiacomo/3120/fix-ad-integ-1111
branch
2 times, most recently
from
50cd082 to
9c2c6cb
Compare
so that the test covers the default values provided by the 1-click template. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…AdminNode, rather than AL2. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
gmarciani
force-pushed
the
wip/mgiacomo/3120/fix-ad-integ-1111
branch
2 times, most recently
from
81fdc50 to
27b35ab
Compare
hgreebe
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Improvements to 1-click template for AD, used by integ tests to cover AD feature.
In particular:
Tests
test_ad_integrationsucceededBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.