Skip to content

[integ-test-framework] Remove check on the number of os, scheduler, instances, regions when existing cluster is specified #6952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2025
+0 −9
Merged

[integ-test-framework] Remove check on the number of os, scheduler, instances, regions when existing cluster is specified #6952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f69ff4
[integ-test-framework] Remove check on the number of os, scheduler, i…
hanwen-cluster Aug 28, 2025
97a0703
Merge branch 'develop' into developaug19
hanwen-cluster Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tests/integration-tests/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,15 +845,6 @@ def _get_config_arguments(args):


def _check_args(args):
# If --cluster is set only one os, scheduler, instance type and region can be provided
if args.cluster:
if len(args.oss) > 1 or len(args.schedulers) > 1 or len(args.instances) > 1 or len(args.regions) > 1:
logger.error(
"when cluster option is specified, you can have a single value for oss, regions, instances "
"and schedulers and you need to make sure they match the cluster specific ones"
)
exit(1)

if not args.tests_config:
assert_that(args.regions).described_as("--regions cannot be empty").is_not_empty()
assert_that(args.instances).described_as("--instances cannot be empty").is_not_empty()
Expand Down
Loading