Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Dec 18, 2025

Description of changes

  • Removing assertion in performance tests which are failing due to detecting degradation when we compare to Hardcoded values which are old and are sensitive to the network topology.
  • Removing tests which are know failures
    • test_queue_parameters_update fails due to a know issue in slurm
    • test_starccm fails in rhel9 for failure like error while loading shared libraries: libnsl.so.1: cannot open shared object file: No such file or directory

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners December 18, 2025 19:33
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Dec 18, 2025
@himani2411 himani2411 changed the title Release 3.14 deps dec16 [3.14.1] Remove tests which are failing due to known issues Dec 18, 2025
@himani2411 himani2411 enabled auto-merge (rebase) December 18, 2025 20:16
@himani2411 himani2411 disabled auto-merge December 18, 2025 20:16
@himani2411 himani2411 force-pushed the release-3.14-deps-dec16 branch from 527d74d to ff37331 Compare December 18, 2025 20:22
@himani2411 himani2411 enabled auto-merge (rebase) December 18, 2025 20:23
Comment on lines 152 to 155
- regions: ["cnn1-az1"]
instances: ["g4dn.2xlarge"]
schedulers: ["slurm"]
oss: ["alinux2023"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this test?
3.10.1 was the urgent patch release to patch China build image (see changelog). We didn't discover the failure because we didn't have the test running in China. We should keep the test to prevent it from happening again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure with 3.10.1 was because of us hardcoding the URL b324f9d in build image.

we added a Fix using Github actions #6575

we see that the Build image intermittently fails in China due to connectivity issue; so we have data points that build image succeeds in China based on the one's which passed.

So i think we can safely remove this for this branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be against removing the test until we reach 100% code-freeze on this branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline we are going to keep the Build Image test in China till we have made final changes for the release.

instances: ["g4dn.2xlarge"]
schedulers: [ "slurm" ]
oss: {{ common.OSS_COMMERCIAL_X86 }}
- regions: ["cnn1-az1"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever we are relaxing, can you please comment it out rather than deleting?

@himani2411 himani2411 force-pushed the release-3.14-deps-dec16 branch from ff37331 to 40f1b6b Compare December 18, 2025 22:05
@himani2411 himani2411 merged commit a4a231b into aws:release-3.14 Dec 18, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants