-
Notifications
You must be signed in to change notification settings - Fork 318
[3.14.1] Remove tests which are failing due to known issues #7160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.14.1] Remove tests which are failing due to known issues #7160
Conversation
527d74d to
ff37331
Compare
| - regions: ["cnn1-az1"] | ||
| instances: ["g4dn.2xlarge"] | ||
| schedulers: ["slurm"] | ||
| oss: ["alinux2023"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this test?
3.10.1 was the urgent patch release to patch China build image (see changelog). We didn't discover the failure because we didn't have the test running in China. We should keep the test to prevent it from happening again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure with 3.10.1 was because of us hardcoding the URL b324f9d in build image.
we added a Fix using Github actions #6575
we see that the Build image intermittently fails in China due to connectivity issue; so we have data points that build image succeeds in China based on the one's which passed.
So i think we can safely remove this for this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be against removing the test until we reach 100% code-freeze on this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline we are going to keep the Build Image test in China till we have made final changes for the release.
| instances: ["g4dn.2xlarge"] | ||
| schedulers: [ "slurm" ] | ||
| oss: {{ common.OSS_COMMERCIAL_X86 }} | ||
| - regions: ["cnn1-az1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever we are relaxing, can you please comment it out rather than deleting?
ff37331 to
40f1b6b
Compare
Description of changes
error while loading shared libraries: libnsl.so.1: cannot open shared object file: No such file or directoryReferences
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.