Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Jan 6, 2026

Description of changes

  • Include subnet hash in both the logical ID and target group name to force replacement when subnet changes.
    This avoids two errors during cluster update when subnet changes:
    1. "target group cannot be associated with more than one load balancer" - solved by new logical ID
    2. "target group name already exists" - solved by new target group name
      Both must change because CloudFormation creates the new resource BEFORE deleting the old one and target group names must be unique within a region/account.

Tests

  • Unit Test
  • Manual Test where I create a cluster with subnet_A and update a cluster with subnet_B when the login Node pool is 0

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested a review from a team as a code owner January 6, 2026 00:10
@himani2411 himani2411 added the 3.x label Jan 6, 2026
@himani2411 himani2411 requested a review from a team as a code owner January 6, 2026 00:10
@himani2411 himani2411 force-pushed the develop-dec22 branch 2 times, most recently from 238ae14 to 24cd038 Compare January 6, 2026 00:11
@himani2411 himani2411 changed the title [Bug] Use subnet hash for ELB target group so that a new target group… [Bug] Use subnet hash to create a new target group if subnetID is updated Jan 6, 2026
Copy link
Contributor

@hehe7318 hehe7318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address the minor format issue.

But the unit tests seems failed. Can you check?

@himani2411
Copy link
Contributor Author

Taking a look at the failures in code-linters

@himani2411 himani2411 force-pushed the develop-dec22 branch 3 times, most recently from 3f2086b to 63c6d31 Compare January 6, 2026 20:20
Himani Anil Deshpande added 2 commits January 6, 2026 15:39
… is created whenever we update the LoginNode's subnetID
@himani2411 himani2411 merged commit 333f51a into aws:develop Jan 6, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants