[Networking] Prevent duplicate security group rules in shared storage security group #7191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-duplicate-sg-rule-0109-1
branch
2 times, most recently
from
5a56e10 to
6bf3fa5
Compare
… security group. The deduplication is beneficial because when duplicate rules are requested, the CFN handler responsible for their creation goes into a path that is more susceptible to eventual consistency issue. When such issue occur, cluster creation may fail. As part of this change, we also applied the same network access scope down we had for login nodes to also head node and compute node. Extending the scope down made the deduplication change easier and it is also beneficial in terms of security posture.
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-duplicate-sg-rule-0109-1
branch
from
6bf3fa5 to
1101295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Prevent duplicate security group rules in shared storage security group.
The deduplication is beneficial because when duplicate rules are requested, the CFN handler responsible for their creation goes into a path that is more susceptible to eventual consistency issue.
When such issue occur, cluster creation may fail.
As part of this change, we also applied the same network access scope down we had for login nodes to also head node and compute node.
Extending the scope down made the deduplication change easier and it is also beneficial in terms of security posture.
Tests
THIS IS A DRAFT UNDER TESTING
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.