[Test] Better cover with unit tests the configuration of shared storage security group and removed unnecessary assertion in integ test #7202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
added
skip-changelog-update
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-sg-0121-1
branch
7 times, most recently
from
9da47ec to
299d48a
Compare
gmarciani
changed the title
gmarciani
changed the title
…ation of the shared storage security group. In particular, the unit tests verifies that the security group has the expected rules in the following cases: 1. Case 1: All nodes use the default (managed) security group 2. Case 2: All nodes use the same custom security group 3. Case 3: All nodes use different custom security groups
… recent changes to scope down networking access for shared storage security group. In particular, those are the expected SG rules: - EFS: - ingress: rule(2049) * (customSG) + rule(all) * (storage) = 2 rules - egress: rule(all traffic) * (customSG + storage) = 2 rules - FSx: - ingress: rule(988,1018-1023) * (customSG) + rule(all) * (storage) = 3 rules - egress: rule(all traffic) * (customSG + storage) = 2 rules
… which is covered by unit test.
gmarciani
force-pushed
the
wip/mgiacomo/3150/test-sg-0121-1
branch
from
299d48a to
e9c8a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSED because we then decided to revert #7193
Description of changes
Consolidated and extended the unit test to verify the configuration of the shared storage security group.
In particular, the unit tests verifies that the security group has the expected rules in the following cases:
Fix assertion in integ test
test_overwrite_sgto reflect the recent changes to scope down networking access for shared storage security group.Tests
test_overwrite_sgBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.