Skip to content

[Test] Add unit test to verify that cluster alarms have the expected settings.#7212

Merged
gmarciani merged 1 commit intoaws:developfrom
gmarciani:wip/mgiacomo/3150/alarms-unit-test-0127-1
Jan 27, 2026
Merged

[Test] Add unit test to verify that cluster alarms have the expected settings.#7212
gmarciani merged 1 commit intoaws:developfrom
gmarciani:wip/mgiacomo/3150/alarms-unit-test-0127-1

Conversation

@gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Jan 27, 2026

Description of changes

Add unit test to verify that cluster alarms have the expected settings.
Before this change we were only testing the existence of the alarms and their type, but not the actual settings.
This is just an improvement of test coverage without any change to source code.

Why now?

  1. Boy scout rule: while working on a task related to alarms, I noticed that our unit test was poor. Such limitation led us to cover the settings of alarms through integ tests rather than unit test.
  2. Having this unit test in place increase our confidence around a refactoring that we are going to do in [Observability] Alarm on clustermgtd not running #7209

Tests

  • Unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 27, 2026
@gmarciani gmarciani requested a review from a team as a code owner January 27, 2026 18:44
@gmarciani gmarciani added the 3.x label Jan 27, 2026
@gmarciani gmarciani requested a review from a team as a code owner January 27, 2026 18:44
@gmarciani gmarciani added the Test label Jan 27, 2026
@gmarciani gmarciani force-pushed the wip/mgiacomo/3150/alarms-unit-test-0127-1 branch from 24c487e to 96cc404 Compare January 27, 2026 18:46
@gmarciani gmarciani enabled auto-merge (rebase) January 27, 2026 18:47
@gmarciani gmarciani merged commit 4295bf2 into aws:develop Jan 27, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants