fix: remove deprecated license classifiers #8211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerena
reviewed
Aug 8, 2025
| @@ -65,7 +65,6 @@ def read_version(): | |||
| "Environment :: Other Environment", | |||
| "Intended Audience :: Developers", | |||
| "Intended Audience :: Information Technology", | |||
| "License :: OSI Approved :: Apache Software License", | |||
There was a problem hiding this comment.
Should we replace this with something else? Is there a new alternative to do this instead of the old License classifier?
If this is currently visible on the generated package, we don't want to just suddenly stop adding the license information.
There was a problem hiding this comment.
The license is already included here.
valerena
approved these changes
Aug 8, 2025
reedham-aws
approved these changes
Aug 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
License classifiers are deprecated. When running
python setup.py --versioncommand is run internally, it also returns a deprecation warning message instead of just the version number, causing a parsing issue. The change on this PR fixes the issue.https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.