Skip to content

Smithy Identity and Auth Refactor (S3) - Rollback Fixed#3296

Closed
sbera87 wants to merge 52 commits intomainfrom
pr-rollback
Closed

Smithy Identity and Auth Refactor (S3) - Rollback Fixed#3296
sbera87 wants to merge 52 commits intomainfrom
pr-rollback

Conversation

@sbera87
Copy link
Copy Markdown
Contributor

@sbera87 sbera87 commented Feb 12, 2025

Issue #, if available:
Smith identity and auth refactor changes for S3 . PR raised with merge conflicts in prior backed out PR.
Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

# This is the 1st commit message:

s3 code gen updates

# This is the commit message #2:

fixes

# This is the commit message #3:

updates

# This is the commit message #4:

updates

# This is the commit message #5:

compiling version

# This is the commit message #6:

updates

# This is the commit message #7:

test changes

# This is the commit message #8:

updates

# This is the commit message #9:

temp changes in s3client

# This is the commit message #10:

for debug

# This is the commit message #11:

Update API model

# This is the commit message #12:

corrects the dual-stack endpoint configuration for cognitoidp
Added DeleteContactFlowVersion API and the CAMPAIGN flow type
AWS IoT SiteWise now supports ingestion and querying of Null (all data types) and NaN (double type) values of bad or uncertain data quality. New partial error handling prevents data loss during ingestion. Enabled by default for new customers; existing customers can opt-in.
Documentation-only update to address doc errors
Documentation-only update: clarified the description of the shareDecaySeconds parameter of the FairsharePolicy data type, clarified the description of the priority parameter of the JobQueueDetail data type.
Added `DigitGroupingStyle` in ThousandsSeparator to allow grouping by `LAKH`( Indian Grouping system ) currency. Support LAKH and `CRORE` currency types in Column Formatting.
This release adds support for the topic attribute FifoThroughputScope for SNS FIFO topics. For details, see the documentation history in the Amazon Simple Notification Service Developer Guide.
Increasing entryPoint in SparkSubmit to accept longer script paths. New limit is 4kb.

# This is the commit message #13:

upgrade smithy version (#3263)


# This is the commit message #14:

Refactor and simplify logic in sdksCommon cmake script to not rely on c2j model (#3251)


# This is the commit message #15:

Update API model

# This is the commit message #16:

Adds multi-turn input support for an Agent node in an Amazon Bedrock Flow
Docs Update for timeout changes
Rename WorkSpaces Web to WorkSpaces Secure Browser
AWS Elemental MediaLive adds a new feature, ID3 segment tagging, in CMAF Ingest output groups. It allows customers to insert ID3 tags into every output segment, controlled by a newly added channel schedule action Id3SegmentTagging.

# This is the commit message #17:

Fix serialization for query xml

# This is the commit message #18:

Update API model

# This is the commit message #19:

Added "future" allocation type for future dated capacity reservation

# This is the commit message #20:

add stable order for smoke tests + restoring client codegen (#3265)


# This is the commit message #21:

add protocol test models (clients+tests) to the repo
fix move assignment /copy constructor
}

class TestSmithyDefaultS3ExpressIdentityProvider : public SmithyDefaultS3ExpressIdentityProvider
{
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to remove this because this test won't work with legacy client.


_mockHttpClient->AddResponseToReturn(mockResponse);

const auto response = _s3Client->MakeRequestDeserialize(&request,
Copy link
Copy Markdown
Contributor Author

@sbera87 sbera87 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to refactor this legacy test case to capture the essence of the test and make it work with both legacy and new client

aws-sdk-cpp-automation and others added 27 commits February 13, 2025 12:12
g Change to be committed:
…ed structures deserialization, payload streaming selection
…mplate. Check public documentation for more information.

This release enables AWS Cost Optimization Hub to show cost optimization recommendations for Amazon Auto Scaling Groups, including those with single and mixed instance types.
Updated list of the valid AWS Region values for the LocationConstraint parameter for general purpose buckets.
We added 5 new stack refactoring APIs: CreateStackRefactor, ExecuteStackRefactor, ListStackRefactors, DescribeStackRefactor, ListStackRefactorActions.
…le positioning metadata, and Extensible Wave Container format

Introduce versionStatus field to take place of status field in EKS DescribeClusterVersions API
Adds documentation for dimension groups and dimensions to analyze locks for Database Insights.
This release adds support for the Clinical Note Template Customization feature for the AWS HealthScribe Streaming APIs within Amazon Transcribe.
This release adds support for the Clinical Note Template Customization feature for the AWS HealthScribe APIs within Amazon Transcribe.
Adds support to handle the new basic scanning daily quota.
…applies to EMAIL contacts.

New vendors for DMS Data Providers: DB2 LUW and DB2 for z/OS
Doc-only update that adds defaults for CloudFront VpcOriginEndpointConfig values.
Documentation updates for Amazon API Gateway
… a revocation configuration option.

Documentation only update for RDS Performance Insights dimensions for execution plans and locking analysis.
Add support for operation level caching
Adding support for the new fullSnapshotSizeInBytes field in the response of the EC2 EBS DescribeSnapshots API. This field represents the size of all the blocks that were written to the source volume at the time the snapshot was created.
…ecutor (#3288)

* Fix Executors destruction deadlock if worker thread owns the Executor

* Refactor DefaultExecutor into PIMPL

* Remove spin lock from thread executor, catch concurrent task submission and shutdown
…teAgent and UpdateAgent operations. Use additionalModelRequestFields to specify additional inference parameters for a model beyond the base inference parameters.

Adds a RequestId parameter to all MediaLive Workflow Monitor create operations.  The RequestId parameter allows idempotent operations.
Support for in-place Lustre version upgrades
Added support for the new voice - Jasmine (en-SG). Jasmine is available as a Neural voice only.
This releases adds the additionalModelRequestFields field to the InvokeInlineAgent operation. Use additionalModelRequestFields to specify  additional inference parameters for a model beyond the base inference parameters.
Custom OpenSearchServerless Entity ID for SAML Config.
Add note for the RUNNER_BUILDKITE_BUILD buildType.
Allow spaces in the following fields in the Partnership resource: ISA 06 - Sender ID, ISA 08 - Receiver ID, GS 02 - Application Sender Code, GS 03 - Application Receiver Code
@sbera87
Copy link
Copy Markdown
Contributor Author

sbera87 commented Feb 13, 2025

raise another with rebased to main

@sbera87 sbera87 closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants