Skip to content

fix mapping of disabled request retry for s3 crt client#3351

Merged
SergeyRyabinin merged 1 commit intomainfrom
sr/allowS3CrtNoRetry
Mar 27, 2025
Merged

fix mapping of disabled request retry for s3 crt client#3351
SergeyRyabinin merged 1 commit intomainfrom
sr/allowS3CrtNoRetry

Conversation

@SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Mar 19, 2025

Issue #, if available:
Unable to disable request retry on S3 CRT client
#2594
https://github.com/awslabs/aws-c-io/pull/694/files
Description of changes:
CRT fixed the support of disabling retries by creating an explicit no retry strategy (instead of using the standard one), so SDK needs to use it.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin merged commit d960f4a into main Mar 27, 2025
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/allowS3CrtNoRetry branch March 27, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants