Reuse checksum on streaming retries + refactor ChecksumInterceptor#3500
Merged
Reuse checksum on streaming retries + refactor ChecksumInterceptor#3500
Conversation
…ility/scalability
…ility/scalability
291e457 to
f2dbd60
Compare
sbiscigl
reviewed
Jul 31, 2025
src/aws-cpp-sdk-core/include/aws/core/AmazonWebServiceRequest.h
Outdated
Show resolved
Hide resolved
src/aws-cpp-sdk-core/include/smithy/client/features/ChecksumInterceptor.h
Show resolved
Hide resolved
| typedef std::function<void(const Aws::Http::HttpRequest&)> RequestSignedHandler; | ||
|
|
||
| struct RetryContext { | ||
| std::pair<Aws::String, std::shared_ptr<Aws::Utils::Crypto::Hash>> m_requestHash; |
Contributor
There was a problem hiding this comment.
this will initialize to
("", nullptr),
which is why you do
if (request.m_retryContext.m_requestHash.second == nullptr) {
later on to check for "absence".
would be better to have this as
std::shared_ptr<std::pair<Aws::String, std::shared_ptr<Aws::Utils::Crypto::Hash>>> m_requestHash
or
Aws::Crt::Optional<std::pair<Aws::String, std::shared_ptr<Aws::Utils::Crypto::Hash>>> m_requestHash
to better call out "absent" or "present"
Contributor
Author
There was a problem hiding this comment.
Fair enough, was keeping it consistent with how we check for absence on the httpRequest itself - httpRequest->GetRequestHash().second == nullptr, but this sounds like a good change, will implement
…dk-cpp into ReuseStreamingChecksum
…ointer to the request hash pair
sbiscigl
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.