Migration Tool AmazonS3URI transform #5990
Conversation
|
| String region = s3Uri.region().map(Region::id).orElse(null); | ||
| boolean isPathStyle = s3Uri.isPathStyle(); | ||
|
|
||
| S3Uri s3UriFromString = /*AWS SDK for Java v2 migration: v2 S3Uri does not URL-encode a String URI. If you relied on this functionality in v1 you must update your code to manually encode the String.*/S3Utilities.builder().build().parseUri(URI.create(uriAsString)); |
There was a problem hiding this comment.
the Comment is kind of in a weird spot, is that what we do elsewhere for similar warning in migration tool?
There was a problem hiding this comment.
Yeah Dongie had same concern. We can't maintain the spacing if put on separate line though. Also for this specific transform can't do it on the line before since we transform the left and right hand sides separately. We could possibly do it on the next line. On the other hand, having it here makes it really obvious to the user
We do the same for other comments fwiw
https://github.com/aws/aws-sdk-java-v2/blob/master/v2-migration/src/test/java/software/amazon/awssdk/v2migration/AddCommentToMethodTest.java#L51
There was a problem hiding this comment.
Yeah, it's great that it is really obvious, just a bit weird. I don't mind it.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Motivation and Context
Transform v1
AmazonS3URIto v2S3Urihttps://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-s3-uri-parser.html
Modifications
new recipe
S3UriToV2Testing
added end to end testing