Skip to content

Providing an idle publisher to resolve race condition #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Providing an idle publisher to resolve race condition #5993

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2898f7
Providing an idle publisher to resolve race condition
RanVaknin Mar 26, 2025
3f55b2e
Using a no-op subscriber
RanVaknin Mar 27, 2025
8a8c1b9
Remove repeated test
RanVaknin Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...est/java/software/amazon/awssdk/core/internal/async/FileAsyncResponseTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,17 @@
import org.apache.commons.lang3.RandomStringUtils;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.RepeatedTest;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import org.reactivestreams.Subscriber;
import org.reactivestreams.Subscription;
import software.amazon.awssdk.core.FileTransformerConfiguration;
import software.amazon.awssdk.core.FileTransformerConfiguration.FileWriteOption;
import software.amazon.awssdk.core.FileTransformerConfiguration.FailureBehavior;
import software.amazon.awssdk.core.async.SdkPublisher;
import software.amazon.awssdk.core.internal.util.NoopSubscription;

/**
* Tests for {@link FileAsyncResponseTransformer}.
Expand Down Expand Up @@ -192,7 +195,7 @@ void exceptionOccurred_deleteFileBehavior(FileTransformerConfiguration configura
Files.write(testPath, "foobar".getBytes(StandardCharsets.UTF_8));
}
FileAsyncResponseTransformer<String> transformer = new FileAsyncResponseTransformer<>(testPath, configuration);
stubException(RandomStringUtils.random(200), transformer);
stubException(transformer);
if (configuration.failureBehavior() == LEAVE) {
assertThat(testPath).exists();
} else {
Expand Down Expand Up @@ -325,18 +328,17 @@ private static void stubSuccessfulStreaming(String newContent, FileAsyncResponse
assertThat(future.isCompletedExceptionally()).isFalse();
}

private static void stubException(String newContent, FileAsyncResponseTransformer<String> transformer) throws Exception {
private static void stubException(FileAsyncResponseTransformer<String> transformer) throws Exception {
CompletableFuture<String> future = transformer.prepare();
transformer.onResponse("foobar");

RuntimeException runtimeException = new RuntimeException("oops");
ByteBuffer content = ByteBuffer.wrap(newContent.getBytes(StandardCharsets.UTF_8));
transformer.onStream(SdkPublisher.adapt(Flowable.just(content, content)));
transformer.onStream(s -> s.onSubscribe(new NoopSubscription(s)));
transformer.exceptionOccurred(runtimeException);

assertThat(future).failsWithin(1, TimeUnit.SECONDS)
.withThrowableOfType(ExecutionException.class)
.withCause(runtimeException);
.withThrowableOfType(ExecutionException.class)
.withCause(runtimeException);
}

private static SdkPublisher<ByteBuffer> testPublisher(String content) {
Expand Down
Loading