Skip to content

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Apr 2, 2025

Motivation and Context

  • Add transforms for additional S3 POJOs
BucketAccelerateConfiguration
MetadataEntry
Tag
CanonicalGrantee
EmailAddressGrantee
MultipartUploadListing
PartListing
PartSummary
RedirectRule
ReplicationDestinationConfig
RoutingRuleCondition
S3ObjectSummary
BucketVersioningConfiguration
Bucket
  • Skip transforming S3 POJO names to pascal case for those that begin with JSON and CSV
JSONType
JSONInput
JSONOutput
CSVInput
CSVOutput
  • Replace all S3 setter/getter method names that contain BucketName with Bucket
  • Replace all S3 POJO names that start with Set to Put
  • Added method transform for getS3AccountOwner() to listBuckets().owner()
  • Skip transforming imports and new POJO() to POJO.builder() for S3 POJOs that do not have v2 equivalent

Testing

Added end to end tests

@davidh44 davidh44 requested a review from a team as a code owner April 2, 2025 16:26
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@davidh44 davidh44 enabled auto-merge April 2, 2025 23:36
@davidh44 davidh44 added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025
@davidh44 davidh44 added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025
@davidh44 davidh44 added this pull request to the merge queue Apr 3, 2025
Merged via the queue into master with commit 4d77b47 Apr 3, 2025
26 of 27 checks passed
@davidh44 davidh44 deleted the hdavidh/migration-tool-s3-pojos branch April 3, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants