Add duplicateAndRenameSharedEvents customization to support event shapes shared with multiple evenstreams #6031
Conversation
|
...sdk/codegen/emitters/customizations/processors/uselegacyeventgenerationscheme/service-2.json
Show resolved
Hide resolved
alextwoods
changed the title
| + "customization config duplicateAndRenameSharedEvents.%s", | ||
| newShapeName, eventStreamName)); | ||
| } | ||
| serviceModel.getShapes().put(newShapeName, eventMemberShape); |
There was a problem hiding this comment.
I may be misunderstanding the intent here, but In this case, is the newShapeName and shapeToDuplicate refers to the same Shape object? Is this the intended behavior, or should we create a deep copy of the Shape object?
There was a problem hiding this comment.
Yea, good call out. I had originally done this to reduce memory but thinking about it more, I think we should deep copy here to prevent possible surprise if anything else is modifying the shapes. I've updated.
|
...software/amazon/awssdk/codegen/customization/processors/EventStreamSharedEventProcessor.java
Show resolved
Hide resolved
Add processor to detect shared events + customization to duplicate.
Motivation and Context
When an event shape is shared between multiple eventstreams, it causes SDK generation/compilation failures. The top level shape POJO implements the event stream interface for each stream and the return type of the
sdkEventTypemethod conflicts.Modifications
This PR adds two things:
duplicateAndRenameSharedEvents)EventStreamSharedEventProcessor) which applies the customization and raises helpful error messages if shared events are detected.Testing
Added new unit tests to cover processor/config. Manual testing of internal service model that raised this issue.
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License