Merged
Conversation
sugmanue
approved these changes
May 1, 2025
Contributor
|
LGTM. Can we add a test for |
kstich
force-pushed
the
kstich/fix-rpcv2-cbor-uris
branch
from
4cb5571 to
7566ba7
Compare
This commit removes the possiblity to customize the HTTP URI for the Smithy RPC v2 CBOR protocol by setting a non-`/` value in the `http` property. It also fixes some typos in the contributing document.
kstich
force-pushed
the
kstich/fix-rpcv2-cbor-uris
branch
from
7566ba7 to
e33ff6e
Compare
dagnir
approved these changes
May 5, 2025
Contributor
|
Integ test is a flaky test failure and is unrelated. Retrying. |
|
Contributor
|
@all-contributors please add @kstich for code |
Contributor
|
I've put up a pull request to add @kstich! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Smithy RPC v2 CBOR does not allow for custom URIs. This PR removes functionality that
would utilize non-
/paths if present in the service model.Modifications
This commit removes the possiblity to customize the HTTP URI for the Smithy RPC v2 CBOR protocol by setting a non-
/value in thehttpproperty.It also fixes some typos in the contributing document.
Testing
Updated the test model to remove the
httpfield.Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License