Merged
Conversation
debora-ito
added
the
changelog-not-required
alextwoods
approved these changes
May 6, 2025
Contributor
alextwoods
left a comment
alextwoods
left a comment
There was a problem hiding this comment.
Nice! Minor comment but otherwise looks good!
| * | ||
| * public void setInternalKey(String internalKey) { | ||
| * return this.internalKey = internalKey;} | ||
| * return this.internalKey = internalKey; |
Contributor
There was a problem hiding this comment.
Is this example code correct? This is a void method (and a setter), so probably shouldn't be returning here.
Member
Author
There was a problem hiding this comment.
I noticed the extra curly, but not the return on a setter 🤦🏻♀️
Fixed now.
Fred1155
approved these changes
May 6, 2025
Contributor
Fred1155
left a comment
Fred1155
left a comment
There was a problem hiding this comment.
LGTM! Though why all github build fail after several seconds
Member
Author
|
@Fred1155 The codebuilds run different when the PR is from a forked repo, don't know why they show duplicate. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some code examples in DynamoDB Enhanced Javadoc are not rendering correctly, like this one in DynamoDbIgnoreNulls:
Modifications
Replace
@codewith@snippetto avoid issues with formatting, improve readability and display examples in a code block.Also fixed some typos and indentation.
Testing
> mvn clean install -pl :dynamodb-enhancedtarget/apidocsfolderScreenshots (if appropriate)
Types of changes
License