Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2-26bdf69.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2",
"contributor": "",
"description": "Add `@Mutable` and `@NotThreadSafe` to model Builders"
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import java.util.Set;
import java.util.function.Consumer;
import javax.lang.model.element.Modifier;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel;
import software.amazon.awssdk.codegen.model.intermediate.MemberModel;
Expand Down Expand Up @@ -83,6 +85,8 @@ public ClassName builderImplName() {
public TypeSpec builderInterface() {
TypeSpec.Builder builder = TypeSpec.interfaceBuilder(builderInterfaceName())
.addSuperinterfaces(builderSuperInterfaces())
.addAnnotation(Mutable.class)
.addAnnotation(NotThreadSafe.class)
.addModifiers(PUBLIC);

shapeModel.getNonStreamingMembers()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.core.SdkBytes;
import software.amazon.awssdk.core.SdkField;
Expand Down Expand Up @@ -1661,6 +1663,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsRequest.Builder, SdkPojo, CopyableBuilder<Builder, AllTypesRequest> {
/**
* Sets the value of the StringMember property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkBytes;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -1660,6 +1662,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsResponse.Builder, SdkPojo, CopyableBuilder<Builder, AllTypesResponse> {
/**
* Sets the value of the StringMember property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkBytes;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -2301,6 +2303,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, AllTypesUnionStructure> {
/**
* Sets the value of the StringMember property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import java.util.function.BiConsumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.core.protocol.MarshallLocation;
Expand Down Expand Up @@ -163,6 +165,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, BaseType> {
/**
* Sets the value of the BaseMember property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -171,6 +173,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsRequest.Builder, SdkPojo, CopyableBuilder<Builder, DeprecatedRenameRequest> {
/**
* Sets the value of the NewNameNoDeprecation property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import java.util.function.BiConsumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.core.protocol.MarshallLocation;
Expand Down Expand Up @@ -158,6 +160,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsResponse.Builder, SdkPojo,
CopyableBuilder<Builder, DeprecatedRenameResponse> {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import java.util.List;
import java.util.Map;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.exception.AwsErrorDetails;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -52,6 +54,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, EmptyModeledException>, JsonProtocolTestsException.Builder {
@Override
Builder awsErrorDetails(AwsErrorDetails awsErrorDetails);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.core.protocol.MarshallLocation;
Expand Down Expand Up @@ -148,6 +150,8 @@ public void accept(EventStreamOperationResponseHandler.Visitor visitor) {
throw new UnsupportedOperationException();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, EventOne> {
/**
* Sets the value of the Foo property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import java.util.Optional;
import java.util.function.Consumer;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -92,6 +94,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsRequest.Builder, SdkPojo,
CopyableBuilder<Builder, EventStreamOperationRequest> {
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import java.util.Map;
import java.util.Optional;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.utils.ToString;
Expand Down Expand Up @@ -90,6 +92,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsResponse.Builder, SdkPojo,
CopyableBuilder<Builder, EventStreamOperationResponse> {
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import java.util.Optional;
import java.util.function.Consumer;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -92,6 +94,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsRequest.Builder, SdkPojo,
CopyableBuilder<Builder, EventStreamOperationWithOnlyInputRequest> {
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import java.util.Map;
import java.util.Optional;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.utils.ToString;
Expand Down Expand Up @@ -88,6 +90,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsResponse.Builder, SdkPojo,
CopyableBuilder<Builder, EventStreamOperationWithOnlyInputResponse> {
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.core.protocol.MarshallLocation;
Expand Down Expand Up @@ -148,6 +150,8 @@ public void accept(EventStreamOperationResponseHandler.Visitor visitor) {
throw new UnsupportedOperationException();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, EventTwo> {
/**
* Sets the value of the Bar property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import java.util.List;
import java.util.Map;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.exception.AwsErrorDetails;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -60,6 +62,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, JsonServiceInternalServerErrorException>,
JsonException.Builder {
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import java.util.List;
import java.util.Map;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.exception.AwsErrorDetails;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -55,6 +57,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, JsonServiceInvalidInputException>, JsonException.Builder {
@Override
Builder awsErrorDetails(AwsErrorDetails awsErrorDetails);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import java.util.List;
import java.util.Map;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.exception.AwsErrorDetails;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -65,6 +67,8 @@ private static Map<String, SdkField<?>> memberNameToFieldInitializer() {
return Collections.emptyMap();
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, JsonServiceThrottlingException>, JsonException.Builder {
@Override
Builder awsErrorDetails(AwsErrorDetails awsErrorDetails);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.awscore.AwsRequestOverrideConfiguration;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -320,6 +322,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsRequest.Builder, SdkPojo,
CopyableBuilder<Builder, ExistenceCheckNamingRequest> {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import java.util.function.BiConsumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.core.protocol.MarshallLocation;
Expand Down Expand Up @@ -318,6 +320,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends JsonProtocolTestsResponse.Builder, SdkPojo,
CopyableBuilder<Builder, ExistenceCheckNamingResponse> {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkBytes;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -145,6 +147,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, InputEvent> {
/**
* Sets the value of the ExplicitPayloadMember property for this object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import java.util.function.Consumer;
import java.util.function.Function;
import software.amazon.awssdk.annotations.Generated;
import software.amazon.awssdk.annotations.Mutable;
import software.amazon.awssdk.annotations.NotThreadSafe;
import software.amazon.awssdk.core.SdkBytes;
import software.amazon.awssdk.core.SdkField;
import software.amazon.awssdk.core.SdkPojo;
Expand Down Expand Up @@ -190,6 +192,8 @@ private static <T> BiConsumer<Object, T> setter(BiConsumer<Builder, T> s) {
return (obj, val) -> s.accept((Builder) obj, val);
}

@Mutable
@NotThreadSafe
public interface Builder extends SdkPojo, CopyableBuilder<Builder, InputEventTwo> {
/**
* Sets the value of the ImplicitPayloadMemberOne property for this object.
Expand Down
Loading
Loading